Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Field Day Field Day
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Field Science
  • Field DayField Day
  • Merge requests
  • !16

Merged
Created Sep 17, 2019 by Craig Earley@craigOwner

enhances database actions activity for small screens, fixes a related crash

  • Overview 0
  • Commits 14
  • Changes 10

One of the few activities and fragments that still suffers on small screens is database actions. This merge request goes a long way to fixing that. Cleaning and erasing buttons are consolidated into a popup menu accessible by touching "Clean or erase". The smaller set of buttons fits comfortably into two rows rather than three or more.

This also patches a bug. Previously, we were not resetting the global trip name setting when erasing the database. That meant that when a user tried to collect data, the app thought there was an underlying database, and therefore did not prompt the user to set up a fresh database, and therefore failed to initialize the site and sector on the sampling activity, and therefore crashed. The trip name now correctly clears when we erase the database.

These changes are fairly well-tested as a matter of functionality, so I'll merge immediately after posting this.

Related to #11 (closed). Consider closing.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: database-actions-design-enhancements